Skip to content

Comments

Bootstrap Ignition shim Asset#2544

Closed
iamemilio wants to merge 2 commits intoopenshift:masterfrom
iamemilio:bootstrap_shim
Closed

Bootstrap Ignition shim Asset#2544
iamemilio wants to merge 2 commits intoopenshift:masterfrom
iamemilio:bootstrap_shim

Conversation

@iamemilio
Copy link

@iamemilio iamemilio commented Oct 21, 2019

Please see the design doc for more information on why this is needed and what our goals are. Please note that this is a WIP for the time being, and is not fully functional or finished.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iamemilio
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2019
@iamemilio iamemilio force-pushed the bootstrap_shim branch 2 times, most recently from f3d99b4 to da4f8da Compare October 23, 2019 13:20
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2019
@iamemilio iamemilio changed the title [WIP] Bootstrap Ignition shim Asset Bootstrap Ignition shim Asset Oct 23, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 23, 2019

/hold

the enhacement needs to be approved before this is merged

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2019
@iamemilio
Copy link
Author

iamemilio commented Oct 24, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2019

@iamemilio: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 5411886 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-openstack 5411886 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iamemilio iamemilio closed this Oct 29, 2019
dlbewley
dlbewley reviewed Nov 20, 2019
View reviewed changes
data/data/config.tf
default = ""

description = <<EOF
(internal) Ignition config file contents. This is autmoatically generated by the installer.
Copy link

@dlbewley dlbewley Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

1 more reviewer

@dlbewley dlbewley dlbewley left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamemilio @openshift-ci-robot @abhinavdahiya @dlbewley